Review Request: Identify SVGs that use system colors with current-color-scheme correctly

Manuel Mommertz 2kmm at gmx.de
Fri Dec 17 22:30:29 CET 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6150/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

The function 'checkColorHints' looks if the bounding rect of the element with the id 'current-color-scheme' is valid. This always fails because this element is a stylesheet and therefore has no rect.
I abstracted the possibility to identify size hints on svg-loading so that it now allows the SharedSvgRenderer to insert interesting elements in the themes rect cache. This is used for the size hints and to insert a valid rect for 'current-color-scheme'.


Diffs
-----

  /trunk/KDE/kdelibs/plasma/private/svg_p.h 1206760 
  /trunk/KDE/kdelibs/plasma/svg.cpp 1206760 

Diff: http://svn.reviewboard.kde.org/r/6150/diff


Testing
-------

Switching themes, switching colors, switching compositing


Thanks,

Manuel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101217/d4e82d40/attachment.htm 


More information about the Plasma-devel mailing list