Review Request: Identify SVGs that use system colors with current-color-scheme correctly

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6150/#review9298
-----------------------------------------------------------

Ship it!



/trunk/KDE/kdelibs/plasma/svg.cpp
<http://svn.reviewboard.kde.org/r/6150/#comment10183>

    const?



/trunk/KDE/kdelibs/plasma/svg.cpp
<http://svn.reviewboard.kde.org/r/6150/#comment10182>

    may as well make it const


- Aaron


On 2010-12-17 21:30:29, Manuel Mommertz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6150/
> -----------------------------------------------------------
> 
> (Updated 2010-12-17 21:30:29)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> The function 'checkColorHints' looks if the bounding rect of the element with the id 'current-color-scheme' is valid. This always fails because this element is a stylesheet and therefore has no rect.
> I abstracted the possibility to identify size hints on svg-loading so that it now allows the SharedSvgRenderer to insert interesting elements in the themes rect cache. This is used for the size hints and to insert a valid rect for 'current-color-scheme'.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/private/svg_p.h 1206760 
>   /trunk/KDE/kdelibs/plasma/svg.cpp 1206760 
> 
> Diff: http://svn.reviewboard.kde.org/r/6150/diff
> 
> 
> Testing
> -------
> 
> Switching themes, switching colors, switching compositing
> 
> 
> Thanks,
> 
> Manuel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101218/e8afc5d6/attachment.html