Review Request: Extend FolderView::configChanged() to reload configuration values

[Sebastian Kügler]

On Sunday 22 August 2010 19:44:36 Harald Sitter wrote:
> /trunk/KDE/kdebase/apps/plasma/applets/folderview/folderview.cpp  (Diff
> revision 7) void FolderView::init()
>   444
>      const QList<int> iconSizes = QList<int>() << 16 << 22 << 32 << 48 <<
> 64 << 128; This is duplicated with configAccepted!
> 
> Due to what this variable actual represents I do not find it wise to have
> two occurances of the same list. Instead it should be turned into
> something static const or a macro if absolutely necessary.

Look at KIconLoader instead of hardcoding these values.
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9