Review Request: Extend FolderView::configChanged() to reload configuration values

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5049/#review7089
-----------------------------------------------------------

Ship it!


this patch was really needed to make folderview correctly controllable via javascript.

to me is good, modulo a couple of style issues below.
if it's ok from fredrik for me it can go in


/trunk/KDE/kdebase/apps/plasma/applets/folderview/folderview.cpp
<http://reviewboard.kde.org/r/5049/#comment7209>

    remove trailing spaces



/trunk/KDE/kdebase/apps/plasma/applets/folderview/folderview.cpp
<http://reviewboard.kde.org/r/5049/#comment7210>

    open curly brace on the previous line



/trunk/KDE/kdebase/apps/plasma/applets/folderview/folderview.cpp
<http://reviewboard.kde.org/r/5049/#comment7211>

    here too


- Marco


On 2010-08-16 14:31:05, Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5049/
> -----------------------------------------------------------
> 
> (Updated 2010-08-16 14:31:05)
> 
> 
> Review request for Plasma and Fredrik Höglund.
> 
> 
> Summary
> -------
> 
> Extend FolderView::configChanged() such that all configuration options are read there on FolderView start. This will ensure that configuration changes made "behind its back" (e.g. by the Desktop Scripting) will take effect.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/plasma/applets/folderview/folderview.cpp 1164320 
> 
> Diff: http://reviewboard.kde.org/r/5049/diff
> 
> 
> Testing
> -------
> 
> Im looking for testers at the moment, but i know for a fact that after applying the patch that kdebase compiles.Will report back when i can get hold of testers and see if it actually works
> 
> 
> Thanks,
> 
> Rohan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100816/c22777a9/attachment.htm