Review Request: Adding a chronometer to the fifteenPuzzle plasmoid

[Alex Raymond]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4870/
-----------------------------------------------------------

(Updated 2010-08-04 18:02:52.817973)


Review request for Plasma and Aaron Seigo.


Changes
-------

Whitespace removed and label created on demand! I've still left the m_things, since it is part of my plans to make it conform to the conventions soon :)


Summary
-------

This patch implements a chronometer for solving the puzzle. It starts as soon as it is shuffled, and automatically ends when the puzzle is sorted. A Plasma::Dialog is shown with the time elapsed after sorting out.


Diffs (updated)
-----

  /trunk/KDE//kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.h 1159197 
  /trunk/KDE//kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.cpp 1159197 
  /trunk/KDE//kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzle.h 1159197 
  /trunk/KDE//kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzle.cpp 1159197 

Diff: http://reviewboard.kde.org/r/4870/diff


Testing
-------

Probably it would only be testable if the position patch is applied, since the initial positions on the current revision create an unsolvable puzzle.


Thanks,

Alex

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100804/47ec1278/attachment.htm