Review Request: Adding a chronometer to the fifteenPuzzle plasmoid

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4870/#review6771
-----------------------------------------------------------

Ship it!


looks good, apart some tiny issues of coding convention and a comment of the label creation.
other than that it can go in


/trunk/KDE//kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.h
<http://reviewboard.kde.org/r/4870/#comment6582>

    whitespace :)



/trunk/KDE//kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.cpp
<http://reviewboard.kde.org/r/4870/#comment6584>

    if (sorted && wasShuffled) {
    
    i know the rest doesn't really follow the conventions but would be good to slowly start to convert it



/trunk/KDE//kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzle.h
<http://reviewboard.kde.org/r/4870/#comment6585>

    whitespace



/trunk/KDE//kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzle.cpp
<http://reviewboard.kde.org/r/4870/#comment6588>

    maybe the label could be created on demand, to make it lighter


- Marco


On 2010-08-03 15:56:36, Alex Raymond wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4870/
> -----------------------------------------------------------
> 
> (Updated 2010-08-03 15:56:36)
> 
> 
> Review request for Plasma and Aaron Seigo.
> 
> 
> Summary
> -------
> 
> This patch implements a chronometer for solving the puzzle. It starts as soon as it is shuffled, and automatically ends when the puzzle is sorted. A Plasma::Dialog is shown with the time elapsed after sorting out.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE//kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.h 1158685 
>   /trunk/KDE//kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.cpp 1158685 
>   /trunk/KDE//kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzle.h 1158685 
>   /trunk/KDE//kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzle.cpp 1158685 
> 
> Diff: http://reviewboard.kde.org/r/4870/diff
> 
> 
> Testing
> -------
> 
> Probably it would only be testable if the position patch is applied, since the initial positions on the current revision create an unsolvable puzzle.
> 
> 
> Thanks,
> 
> Alex
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100803/d25b8f5d/attachment-0001.htm