Review Request: Adding a chronometer to the fifteenPuzzle plasmoid

Aaron Seigo aseigo at kde.org
Wed Aug 4 20:16:16 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4870/#review6795
-----------------------------------------------------------


nice idea!

instead of a popup dialog, how about putting a QGraphicsWidget over the Applet with the message? perhaps even Plasma::Applet::showMessage?

- Aaron


On 2010-08-04 18:02:52, Alex Raymond wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4870/
> -----------------------------------------------------------
> 
> (Updated 2010-08-04 18:02:52)
> 
> 
> Review request for Plasma and Aaron Seigo.
> 
> 
> Summary
> -------
> 
> This patch implements a chronometer for solving the puzzle. It starts as soon as it is shuffled, and automatically ends when the puzzle is sorted. A Plasma::Dialog is shown with the time elapsed after sorting out.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE//kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.h 1159197 
>   /trunk/KDE//kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.cpp 1159197 
>   /trunk/KDE//kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzle.h 1159197 
>   /trunk/KDE//kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzle.cpp 1159197 
> 
> Diff: http://reviewboard.kde.org/r/4870/diff
> 
> 
> Testing
> -------
> 
> Probably it would only be testable if the position patch is applied, since the initial positions on the current revision create an unsolvable puzzle.
> 
> 
> Thanks,
> 
> Alex
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100804/56e67579/attachment.htm 


More information about the Plasma-devel mailing list