Review Request: [Quicklaunch] Refactoring of the Quicklaunch applet

[Lukas Appelhans]

Am Montag 26 April 2010 15:48:27 schrieb Ingomar Wesp:
> >>> And I think the column setting is unnecessary... no? :)
> >> 
> >> I'm afraid I'm not sure what you are referring to.
> >> Do you mean the ability to set the maximum number of columns in vertical
> >> formfactors?
> > 
> > No, in horizontal formfactors there's an option to force the number of
> > columns, it's just a checkbox...
> 
> Ah, now I think I know what you mean ;)
> 
> If I'm right, you are referring to the planar form factor (applet on
> desktop / in plasmoidviewer). If you would see "Force column settings" in
> the settings of the quicklaunch applet in a horizontal form factor (for
> example, in a horizontal panel), that would be a bug …
> 
> Currently, the configuration settings are (actually, the underlying
> settings are the same, but the user visible strings are different):
> 
> formFactor == Plasma::horizontal:
>   Force row settings
>   Max rows count
> else
>   Force column settings
>   Max column count
> 
> But you are right that "Force column settings" is probably unnecessary in a
> planar form factor (at least I'm having trouble finding a use case for
> that). If you can confirm that I'm understanding you right, I'll remove
> the visibility for this setting in this case.
Ahh true, it was force column settings as the applet was in plasmoidviewer... 
in panel it worked greatly (I had overlooked/wrong seen some stuff it seems... 
I  just tested again =))...

Can you make the configuration of the rows first and then have the force 
setting (aka swap the place of them), that'd make more sense to me as the user 
reads the options from top to bottom, not knowing that there are any 
row/column settings... :)

Except that the patch is absuletely fine to go in... the applet now has a much 
better quality than before... :)

Btw, as you pretty much rewrote the applet, may you also take over the 
maintainership? :)

Lukas
> 
> Best regards,
> Ingo
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel