Review Request: use QGraphicsOpacityEffect in FadeAnimation

[Adenilson Cavalcanti]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1860/#review2675
-----------------------------------------------------------



/trunk/KDE/kdelibs/plasma/animations/fade.cpp
<http://reviewboard.kde.org/r/1860/#comment1984>

    I guess that FadeAnimation destructor will have to delete (otherwise it will leak the memory).


- Adenilson


On 2009-10-16 16:49:53, Giulio Camuffo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1860/
> -----------------------------------------------------------
> 
> (Updated 2009-10-16 16:49:53)
> 
> 
> Review request for Plasma and Adenilson Cavalcanti.
> 
> 
> Summary
> -------
> 
> This little patch makes the FadeAnimation use QGraphicsOpacityEffect instead of setting the opacity directly on the widget.
> This solves a graphical glitch with Plasma::Label.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/animations/abstractanimation.cpp 1036122 
>   /trunk/KDE/kdelibs/plasma/animations/fade.h 1036122 
>   /trunk/KDE/kdelibs/plasma/animations/fade.cpp 1036122 
> 
> Diff: http://reviewboard.kde.org/r/1860/diff
> 
> 
> Testing
> -------
> 
> tested, works
> 
> 
> Thanks,
> 
> Giulio
> 
>