Review Request: use QGraphicsOpacityEffect in FadeAnimation

Giulio Camuffo giuliocamuffo at gmail.com
Fri Oct 16 18:49:53 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1860/
-----------------------------------------------------------

(Updated 2009-10-16 16:49:53.459654)


Review request for Plasma and Adenilson Cavalcanti.


Changes
-------

added a private class
in setwidget delete the opacity effect that was applied to the possible previous item


Summary
-------

This little patch makes the FadeAnimation use QGraphicsOpacityEffect instead of setting the opacity directly on the widget.
This solves a graphical glitch with Plasma::Label.


Diffs (updated)
-----

  /trunk/KDE/kdelibs/plasma/animations/abstractanimation.cpp 1036122 
  /trunk/KDE/kdelibs/plasma/animations/fade.h 1036122 
  /trunk/KDE/kdelibs/plasma/animations/fade.cpp 1036122 

Diff: http://reviewboard.kde.org/r/1860/diff


Testing
-------

tested, works


Thanks,

Giulio



More information about the Plasma-devel mailing list