Review Request: use QGraphicsOpacityEffect in FadeAnimation
Giulio Camuffo
giuliocamuffo at gmail.com
Tue Oct 20 19:15:16 CEST 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1860/
-----------------------------------------------------------
(Updated 2009-10-20 17:15:16.202552)
Review request for Plasma and Adenilson Cavalcanti.
Changes
-------
deletes private class in destructor
updated to the last rev
AbstractAnimation::AbstractAnimation() sets d->animObject to 0
Summary
-------
This little patch makes the FadeAnimation use QGraphicsOpacityEffect instead of setting the opacity directly on the widget.
This solves a graphical glitch with Plasma::Label.
Diffs (updated)
-----
/trunk/KDE/kdelibs/plasma/animations/abstractanimation.cpp 1038071
/trunk/KDE/kdelibs/plasma/animations/fade.h 1038071
/trunk/KDE/kdelibs/plasma/animations/fade.cpp 1038071
Diff: http://reviewboard.kde.org/r/1860/diff
Testing
-------
tested, works
Thanks,
Giulio
More information about the Plasma-devel
mailing list