Review Request: Delays ensureRectVisible() to allow the widget to resize

Giulio Camuffo giuliocamuffo at gmail.com
Sat Oct 3 10:17:56 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1759/
-----------------------------------------------------------

(Updated 2009-10-03 08:17:56.459735)


Review request for Plasma, Aaron Seigo and Marco Martin.


Changes
-------

added ensureItemVisible(QGraphicsItem *) that delays the scroll, while ensureRectVisible scrolls the view immediately


Summary
-------

This patch solves a bug with ensureRectVisible(). It is brother of this: http://reviewboard.kde.org/r/1756/
It delays the scrolling of the view because it has to wait for the widget managed to resize itself if it's needed, so it doesn't take a part of the rect that has to be visible still out of the viewable view.


Diffs (updated)
-----

  /trunk/KDE/kdelibs/plasma/widgets/scrollwidget.h 1030622 
  /trunk/KDE/kdelibs/plasma/widgets/scrollwidget.cpp 1030622 

Diff: http://reviewboard.kde.org/r/1759/diff


Testing
-------

it simply works(tm) :P the parent is resized and the rect is ensured visible in all its parts.


Thanks,

Giulio



More information about the Plasma-devel mailing list