Review Request: Delays ensureRectVisible() to allow the widget to resize

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1759/#review2542
-----------------------------------------------------------

Ship it!


to me is ok, just that small issue below


/trunk/KDE/kdelibs/plasma/widgets/scrollwidget.cpp
<http://reviewboard.kde.org/r/1759/#comment1863>

    i think there should be a check on the parentItem hierarchy to see if item is actually a descendant of d->widget other wise insane rects could be calculated?


- Marco


On 2009-10-03 08:17:56, Giulio Camuffo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1759/
> -----------------------------------------------------------
> 
> (Updated 2009-10-03 08:17:56)
> 
> 
> Review request for Plasma, Aaron Seigo and Marco Martin.
> 
> 
> Summary
> -------
> 
> This patch solves a bug with ensureRectVisible(). It is brother of this: http://reviewboard.kde.org/r/1756/
> It delays the scrolling of the view because it has to wait for the widget managed to resize itself if it's needed, so it doesn't take a part of the rect that has to be visible still out of the viewable view.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/widgets/scrollwidget.h 1030622 
>   /trunk/KDE/kdelibs/plasma/widgets/scrollwidget.cpp 1030622 
> 
> Diff: http://reviewboard.kde.org/r/1759/diff
> 
> 
> Testing
> -------
> 
> it simply works(tm) :P the parent is resized and the rect is ensured visible in all its parts.
> 
> 
> Thanks,
> 
> Giulio
> 
>