Review Request: Delays ensureRectVisible() to allow the widget to resize

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1759/#review2530
-----------------------------------------------------------


to me the only question is: are there enough use cases? probably yes, depends on the scenario you call ensurevisiblerect.
what i think could be done instead is:
ensurevisiblerect, as is now.
ensurevisibleite: the parameter is a widget child, so we know we don't want explicitl a rect passed as parameter but an item, whatever is its rect, and this will be delayed.

it should semplify a bit a bunch of code arond even.

- Marco


On 2009-10-02 19:53:47, Giulio Camuffo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1759/
> -----------------------------------------------------------
> 
> (Updated 2009-10-02 19:53:47)
> 
> 
> Review request for Plasma, Aaron Seigo and Marco Martin.
> 
> 
> Summary
> -------
> 
> This patch solves a bug with ensureRectVisible(). It is brother of this: http://reviewboard.kde.org/r/1756/
> It delays the scrolling of the view because it has to wait for the widget managed to resize itself if it's needed, so it doesn't take a part of the rect that has to be visible still out of the viewable view.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/widgets/scrollwidget.h 1030622 
>   /trunk/KDE/kdelibs/plasma/widgets/scrollwidget.cpp 1030622 
> 
> Diff: http://reviewboard.kde.org/r/1759/diff
> 
> 
> Testing
> -------
> 
> it simply works(tm) :P the parent is resized and the rect is ensured visible in all its parts.
> 
> 
> Thanks,
> 
> Giulio
> 
>