Review Request: About, stop and uninstall buttons in widget explorer

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2213/#review3170
-----------------------------------------------------------


the about dialog positions oddly and when clicked on makes the add widgets disappear. i wonder if we could embed the about information in the tooltip as annieC had it at one point?

instead of "Stop Running Widgets" (which to me at least implies they'll just be halted, in a reversable manner) it should probably be "Removed Running %1" where %1 is the name of the widget. however, i'm not even sure we need or want that. the use case seems very suspect to me and we purposefully didn't include it in the add widgets interface, particularly because it doesn't say which widgets would be removed and could be rather unexpected. how often does one really want to remove all of one kind of widget? hm.

speaking of closing and removing, we also need a close button in the add widgets interface itself, to the right of the categories tab widget. i should get on that.

- Aaron


On 2009-11-19 14:15:26, Petri Damstén wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2213/
> -----------------------------------------------------------
> 
> (Updated 2009-11-19 14:15:26)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Mostly copy/paste code.
> TODO:
> * How to hide widget explorer when about pressed?
> * Buttons seem to take space in layout even when hidden, so removing/adding now
> * Some layout issues on first show
> * list must be updated on uninstall/stop
> * recycle about dialog (todo from old add widgets dialog)
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsExplorer/appletslist.h 1051459 
>   /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsExplorer/appletslist.cpp 1051459 
>   /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsExplorer/applettooltip.h 1051459 
>   /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsExplorer/applettooltip.cpp 1051459 
>   /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsExplorer/widgetexplorer.h 1051459 
>   /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsExplorer/widgetexplorer.cpp 1051459 
> 
> Diff: http://reviewboard.kde.org/r/2213/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Petri
> 
>