Review Request: About, stop and uninstall buttons in widget explorer

Petri Damstén petri.damsten at gmail.com
Thu Nov 19 15:15:27 CET 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2213/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

Mostly copy/paste code.
TODO:
* How to hide widget explorer when about pressed?
* Buttons seem to take space in layout even when hidden, so removing/adding now
* Some layout issues on first show
* list must be updated on uninstall/stop
* recycle about dialog (todo from old add widgets dialog)


Diffs
-----

  /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsExplorer/appletslist.h 1051459 
  /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsExplorer/appletslist.cpp 1051459 
  /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsExplorer/applettooltip.h 1051459 
  /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsExplorer/applettooltip.cpp 1051459 
  /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsExplorer/widgetexplorer.h 1051459 
  /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsExplorer/widgetexplorer.cpp 1051459 

Diff: http://reviewboard.kde.org/r/2213/diff


Testing
-------


Thanks,

Petri



More information about the Plasma-devel mailing list