Review Request: About, stop and uninstall buttons in widget explorer

[Petri Damstén]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2213/
-----------------------------------------------------------

(Updated 2009-11-20 13:51:32.753648)


Review request for Plasma.


Changes
-------

* About data in tooltip. If this http://teom.wordpress.com/2009/08/23/social-desktop-integration-in-kaboutdialog/ goes to kdelibs it could be nice for plasmoids too.
* No stop button. I kind a liked it in previous add dialog, but it's true that it's not needed for general use.

There is code for handling ksycoca database changes in model but the icon is not removed on uninstall. I'll investigate it further next week or if someone more familiar with this code can take a look it would be great.


Summary
-------

Mostly copy/paste code.
TODO:
* How to hide widget explorer when about pressed?
* Buttons seem to take space in layout even when hidden, so removing/adding now
* Some layout issues on first show
* list must be updated on uninstall/stop
* recycle about dialog (todo from old add widgets dialog)


Diffs (updated)
-----

  /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsExplorer/appletslist.cpp 1051785 
  /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsExplorer/applettooltip.h 1051785 
  /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsExplorer/applettooltip.cpp 1051785 
  /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsExplorer/widgetexplorer.h 1051785 
  /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsExplorer/widgetexplorer.cpp 1051785 

Diff: http://reviewboard.kde.org/r/2213/diff


Testing
-------


Thanks,

Petri