KDE/kdelibs/plasma

[Aaron J. Seigo]

On Thursday 30 April 2009, Aaron J. Seigo wrote:
> On Thursday 30 April 2009, David Nolden wrote:
> > SVN commit 961915 by zwabel:
> >
> > - Allow painting a background color, or a background pattern behind
> > freely floating elements of the theme, to provide a better fallback
> > mechanism for transparent themes when composition is not available. The
> > color/pattern is
>
> please revert this commit. (or i will.)

i have reverted these changes, given that David evidently isn't going to.

in fact, there was a new commit today that withdrew the public API bits (which 
is good) but completely failed to address any of the actual design issues 
raised.

David, plasma is not a place where you can simply shove code through simply on 
the merit that you have an svn account. we work together, towards consensus 
and try and keep things focused and on-track. there was discussion about what 
would be workable (a colour wash behind the transparent versions of the svgs, 
drawn from the theme config itself), and if you wish to implement that please 
do so (though please follow the coding style guide; we use the kdelibs coding 
style in libplasma).

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090501/5995fc8e/attachment.sig