Review Request: config

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/639/#review1012
-----------------------------------------------------------



/trunk/KDE/kdelibs/plasma/applet.h
<http://reviewboard.kde.org/r/639/#comment687>

    could this be put into AppletPrivate instead?



/trunk/KDE/kdelibs/plasma/containment.h
<http://reviewboard.kde.org/r/639/#comment688>

    ContainmentPrivate?



/trunk/KDE/kdelibs/plasma/corona.h
<http://reviewboard.kde.org/r/639/#comment684>

    does this belong in libplasma or in the application (e.g. plasma-desktop)?



/trunk/KDE/kdelibs/plasma/corona.h
<http://reviewboard.kde.org/r/639/#comment686>

    what is the use case for this outside of libplasma? i get the feeling that this could be kept entirely internal?



/trunk/KDE/kdelibs/plasma/corona.cpp
<http://reviewboard.kde.org/r/639/#comment689>

    why two collections of the same actions? aActions (appletActions?) doesn't seem to be doing anything?



/trunk/KDE/kdelibs/plasma/corona.cpp
<http://reviewboard.kde.org/r/639/#comment685>

    this needs to be non-modular, though i think you covered that in your comments.


- Aaron


On 2009-04-29 23:58:24, Chani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/639/
> -----------------------------------------------------------
> 
> (Updated 2009-04-29 23:58:24)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> -it's still modal
> -needs testing without my local patch that fixes a qt shortcut bug
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/applet.h 960161 
>   /trunk/KDE/kdelibs/plasma/applet.cpp 960161 
>   /trunk/KDE/kdelibs/plasma/containment.h 960161 
>   /trunk/KDE/kdelibs/plasma/containment.cpp 960161 
>   /trunk/KDE/kdelibs/plasma/corona.h 960161 
>   /trunk/KDE/kdelibs/plasma/corona.cpp 960161 
>   /trunk/KDE/kdelibs/plasma/private/applet_p.h 960161 
>   /trunk/KDE/kdelibs/plasma/private/containment_p.h 960161 
> 
> Diff: http://reviewboard.kde.org/r/639/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chani
> 
>