Review Request: Patch to add free space indicator into device notifier plasmoid

[Christopher Blauvelt]

On Tue, Apr 28, 2009 at 7:29 AM, <martin.klapetek at gmail.com> wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/632/
> -----------------------------------------------------------
>
> (Updated 2009-04-28 04:29:44.782996)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> This is more like a proof of concept, for me to see if I'm on the right way
> with this one
>
>
> Diffs (updated)
> -----
>
>  trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/CMakeLists.txt
> 958067
>  trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h
> 958067
>  trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp
> 958067
>  trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfo.h
> PRE-CREATION
>  trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfo.cpp
> PRE-CREATION
>  trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.h
> PRE-CREATION
>  trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp
> PRE-CREATION
>  trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.h
> 958067
>  trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp
> 958067
>  trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.h
> 958067
>  trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp
> 958067
>
> Diff: http://reviewboard.kde.org/r/632/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> mck182
>
>
I've gone through and changed a few things that needed to be done.  These
changes use the soliddevice data engine to get free space and updates to
that value.  This has the effect of:
a) using values that are already present and being collected, less memory
usage.
b) avoids using an internal timer but instead uses the one that is already
set through the dataengine
c) only changes things in the delegate when the view says so

I've tested it and it works.  The only bug is that the view will only update
while the mouse is over the applet.
Chris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20090501/55a61f6f/attachment-0001.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: notifier-svn.diff
Type: text/x-patch
Size: 13077 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090501/55a61f6f/attachment-0002.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: notifier-mck182.diff
Type: text/x-patch
Size: 17356 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090501/55a61f6f/attachment-0003.diff