<br><br><div class="gmail_quote">On Tue, Apr 28, 2009 at 7:29 AM, <span dir="ltr"><<a href="mailto:martin.klapetek@gmail.com">martin.klapetek@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="im"><br>
-----------------------------------------------------------<br>
This is an automatically generated e-mail. To reply, visit:<br>
<a href="http://reviewboard.kde.org/r/632/" target="_blank">http://reviewboard.kde.org/r/632/</a><br>
-----------------------------------------------------------<br>
<br>
</div>(Updated 2009-04-28 04:29:44.782996)<br>
<br>
<br>
Review request for Plasma.<br>
<div class="im"><br>
<br>
Summary<br>
-------<br>
<br>
This is more like a proof of concept, for me to see if I'm on the right way with this one<br>
<br>
<br>
Diffs (updated)<br>
-----<br>
<br>
trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/CMakeLists.txt 958067<br>
trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h 958067<br>
</div> trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp 958067<br>
<div><div></div><div class="h5"> trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfo.h PRE-CREATION<br>
trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfo.cpp PRE-CREATION<br>
trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.h PRE-CREATION<br>
trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp PRE-CREATION<br>
trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.h 958067<br>
trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp 958067<br>
trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.h 958067<br>
trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp 958067<br>
<br>
Diff: <a href="http://reviewboard.kde.org/r/632/diff" target="_blank">http://reviewboard.kde.org/r/632/diff</a><br>
<br>
<br>
Testing<br>
-------<br>
<br>
<br>
Thanks,<br>
<br>
mck182<br>
<br>
</div></div></blockquote></div><br>I've gone through and changed a few things that needed to be done. These changes use the soliddevice data engine to get free space and updates to that value. This has the effect of:<br>
a) using values that are already present and being collected, less memory usage.<br>b) avoids using an internal timer but instead uses the one that is already set through the dataengine<br>c) only changes things in the delegate when the view says so<br>
<br>I've tested it and it works. The only bug is that the view will only update while the mouse is over the applet.<br>Chris<br>