Incompatible change to libs/plasmaclock?

[Aaron J. Seigo]

On Sunday 22 March 2009, Michael Pyne wrote:
> Revision 942893 (http://websvn.kde.org/?view=rev&revision=942893) broke the
> kdebase build for me (a rename of a .ui file).

it's already been fixed in svn... however:

> I would have just fixed it, but I noticed the offending line is a INSTALL
> entry in CMakeLists.txt.  If we were installing the ui_.h file before (i.e.
> it's some kind of public interface) is it OK to just change the name all of
> a sudden?  

it's not actually a public library, but still not great practice.

> Or does this ui_calendarConfig.h file need installed at all (if
> not I'd just remove it I think).

nope, it's not. nothing uses it, and as an autogen'd file it should never have 
been installed. away it goes!

thanks for the heads up...

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090322/86d4f5cc/attachment.sig