Review Request: Check file timestamp on Plasma::Svg cache

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/343/#review515
-----------------------------------------------------------

Ship it!


widgets should really not be putting random images into the theme folders unless they are to be part of the theme proper, which means this timestamp stuff shouldn't be necessary. (such widgets can also touch the metadata.desktop file...) in any case, there are two small style issues to take care of, but it can go in  ...


/trunk/KDE/kdelibs/plasma/svg.cpp
<http://reviewboard.kde.org/r/343/#comment312>

    space between "if" and "("



/trunk/KDE/kdelibs/plasma/theme.cpp
<http://reviewboard.kde.org/r/343/#comment311>

    space between "if" and "("


- Aaron


On 2009-03-17 10:51:47, Arthur Mello wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/343/
> -----------------------------------------------------------
> 
> (Updated 2009-03-17 10:51:47)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Add support to check with file timestamp if cache for Plasma::Svg is still valid. Today a entry on cache is discarded only if we have a Theme/Colour change. This way if the svg file is changed a plasmoid will keep using the old image. The file timest
> amp is checked only on setImagePath to avoid a overhead every time a svg is loaded.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/svg.cpp 940566 
>   /trunk/KDE/kdelibs/plasma/theme.h 940566 
>   /trunk/KDE/kdelibs/plasma/theme.cpp 940566 
> 
> Diff: http://reviewboard.kde.org/r/343/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arthur
> 
>