Review Request: Check file timestamp on Plasma::Svg cache

[Arthur Mello]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/343/
-----------------------------------------------------------

(Updated 2009-03-17 10:51:47.694480)


Review request for Plasma.


Changes
-------

Updated patch with Aaron's comments.
With the new "if(!themed)" test, svg files that are part of theme will never check timestamp.
If some plasmoid keeps images inside theme folder and update it without a theme update the cache will not discard the old pixmap until a theme change. But not sure if this is a valid user case.


Summary
-------

Add support to check with file timestamp if cache for Plasma::Svg is still valid. Today a entry on cache is discarded only if we have a Theme/Colour change. This way if the svg file is changed a plasmoid will keep using the old image. The file timest
amp is checked only on setImagePath to avoid a overhead every time a svg is loaded.


Diffs (updated)
-----

  /trunk/KDE/kdelibs/plasma/svg.cpp 940566 
  /trunk/KDE/kdelibs/plasma/theme.h 940566 
  /trunk/KDE/kdelibs/plasma/theme.cpp 940566 

Diff: http://reviewboard.kde.org/r/343/diff


Testing
-------


Thanks,

Arthur