Review Request: a thinghiesimilar to the toolbox on zoomed out view

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/265/
-----------------------------------------------------------

(Updated 2009-03-10 14:11:50.513272)


Review request for Plasma.


Changes
-------

now uses chani's corona actions and is in plasmaapp instead of desktopview to appear just in one monitor instead of all of them. a problem is that we would want the lock widget option to appear in the containment when fully zoomed in, and only outside when zoomed out, can't see other solutions to have different copies of those actions for each containment, not really pretty


Summary
-------

A problem of the zoomed out view is that the add activity button doesn't belong to the toolbox of each containment (even if technically is an action done by the containment class)
what i think works better is something else that groups the actions more global, like this one (here the add activity of the active containment when it was zoomed out is used)
other stuff that could go here are some config options, like per panel desktop view, dashboard follows activity and stuff like that, don't know if it could totally replace a kcm, but i think at least attempting to avoid one would be good :)
a thing that still needs is a clean way to hide the add activity actions from containments


Diffs (updated)
-----

  /trunk/KDE/kdebase/workspace/plasma/shells/desktop/plasmaapp.h 935592 
  /trunk/KDE/kdebase/workspace/plasma/shells/desktop/plasmaapp.cpp 935592 

Diff: http://reviewboard.kde.org/r/265/diff


Testing
-------


Screenshots
-----------


  http://reviewboard.kde.org/r/265/s/53/


Thanks,

Marco