Review Request: a thinghiesimilar to the toolbox on zoomed out view

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/265/#review446
-----------------------------------------------------------

Ship it!


i like the idea; let's try it out! :)


/trunk/KDE/kdebase/workspace/plasma/shells/desktop/plasmaapp.cpp
<http://reviewboard.kde.org/r/265/#comment282>

    don't really need to check m_controllerDialog


- Aaron


On 2009-03-10 14:11:50, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/265/
> -----------------------------------------------------------
> 
> (Updated 2009-03-10 14:11:50)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> A problem of the zoomed out view is that the add activity button doesn't belong to the toolbox of each containment (even if technically is an action done by the containment class)
> what i think works better is something else that groups the actions more global, like this one (here the add activity of the active containment when it was zoomed out is used)
> other stuff that could go here are some config options, like per panel desktop view, dashboard follows activity and stuff like that, don't know if it could totally replace a kcm, but i think at least attempting to avoid one would be good :)
> a thing that still needs is a clean way to hide the add activity actions from containments
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/plasmaapp.h 935592 
>   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/plasmaapp.cpp 935592 
> 
> Diff: http://reviewboard.kde.org/r/265/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://reviewboard.kde.org/r/265/s/53/
> 
> 
> Thanks,
> 
> Marco
> 
>