Review Request: a thinghiesimilar to the toolbox on zoomed out view

[Marco Martin]

> On 2009-03-08 15:45:57, Chani wrote:
> > ahahaha. we need to talk more. :)
> > I started work on this today, but from a different angle. my patch adds an actioncollection to corona for the actions that really belong to it and not the containments. I wasn't looking forward to figuring out how to display them, and now I don't have to. :) it looks like our patches will complement each other.
> > I need to start on dinner now - ping me later...

yeah, it's prefectly complementary, because i was really unhappy with taking an action from a containment and find an hacky way to hide it then...
i'm avail from now on, so your early morning :p


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/265/#review421
-----------------------------------------------------------


On 2009-03-08 14:43:50, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/265/
> -----------------------------------------------------------
> 
> (Updated 2009-03-08 14:43:50)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> A problem of the zoomed out view is that the add activity button doesn't belong to the toolbox of each containment (even if technically is an action done by the containment class)
> what i think works better is something else that groups the actions more global, like this one (here the add activity of the active containment when it was zoomed out is used)
> other stuff that could go here are some config options, like per panel desktop view, dashboard follows activity and stuff like that, don't know if it could totally replace a kcm, but i think at least attempting to avoid one would be good :)
> a thing that still needs is a clean way to hide the add activity actions from containments
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/desktopview.h 935592 
>   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/desktopview.cpp 935592 
> 
> Diff: http://reviewboard.kde.org/r/265/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://reviewboard.kde.org/r/265/s/53/
> 
> 
> Thanks,
> 
> Marco
> 
>