What to do with the old Plasma::Animator?

[Alexis Ménard]

On Fri, Jun 12, 2009 at 3:40 PM, Akmanalp, Mehmet A <makmanalp at wpi.edu>wrote:

> Regarding these:
>
> On Thu, Jun 4, 2009 at 9:39 PM, Alexis Ménard<menard at kde.org> wrote:
> >
> >
> > On Thu, Jun 4, 2009 at 7:16 PM, Aaron J. Seigo <aseigo at kde.org> wrote:
> >> can we just extend Plasma::Animator with the new methods and deprecate
> all
> >> the
> >> old stuff?
> >>
> >> to keep the implementation from becoming mixed up with all the old
> crufty
> >> stuff, we could move the current animator.cpp somewhere else
> >> (deprecated/animator.cpp? private/animator.cpp?) and name the new, fresh
> >> and
> >> happy implementation file animator.cpp.
> >
> > Yep as soon as the old stuff is properly documented as obslelete and you
> > hide it deeply in the h file, that's how we do in Qt.
> > Having a new file can be better if the choice is possible.
> >>
> >> the other option would be AnimationFactory, but then things gets
> confusing
> >> in libplasma imho. i'd much rather just retro-fit Animation.
> >
> >
> > I really like the factory concept : give me blur animation object which i
> > can set-up and put into groups if needed...
>
> So, I've been thinking, and I'm a little confused. Do we:
>
> 1) Move the old animator.cpp into deprecated/ and create a whole new
> animator.cpp with a whole new Plasma::Animator? If so, how is this
> "extend Plasma::Animator"?


Yes move it just. And create a new class for now.


>
> 2) Move the old animator.cpp into deprecated/ and extend it in the new
> animator.cpp? Then, this doesn't solve the naming issue(We still have
> to use a different name, not "Animator"), and it isn't "retro-fitting
> Animation".


You can't remove it completly, symbols have to be here for binary
compatibilty reasons.
Grab a name (can't be Animator), the one you want, we will see later.


>
> 3) Something else that I didn't quite get?
>
> --
> ~ mali (http://constant.inople.net/)
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20090612/b792e0e6/attachment.htm