<br><br><div class="gmail_quote">On Fri, Jun 12, 2009 at 3:40 PM, Akmanalp, Mehmet A <span dir="ltr"><<a href="mailto:makmanalp@wpi.edu">makmanalp@wpi.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Regarding these:<br>
<br>
On Thu, Jun 4, 2009 at 9:39 PM, Alexis Ménard<<a href="mailto:menard@kde.org">menard@kde.org</a>> wrote:<br>
><br>
><br>
> On Thu, Jun 4, 2009 at 7:16 PM, Aaron J. Seigo <<a href="mailto:aseigo@kde.org">aseigo@kde.org</a>> wrote:<br>
>> can we just extend Plasma::Animator with the new methods and deprecate all<br>
>> the<br>
>> old stuff?<br>
>><br>
>> to keep the implementation from becoming mixed up with all the old crufty<br>
>> stuff, we could move the current animator.cpp somewhere else<br>
>> (deprecated/animator.cpp? private/animator.cpp?) and name the new, fresh<br>
>> and<br>
>> happy implementation file animator.cpp.<br>
><br>
> Yep as soon as the old stuff is properly documented as obslelete and you<br>
> hide it deeply in the h file, that's how we do in Qt.<br>
> Having a new file can be better if the choice is possible.<br>
>><br>
>> the other option would be AnimationFactory, but then things gets confusing<br>
>> in libplasma imho. i'd much rather just retro-fit Animation.<br>
><br>
><br>
> I really like the factory concept : give me blur animation object which i<br>
> can set-up and put into groups if needed...<br>
<br>
So, I've been thinking, and I'm a little confused. Do we:<br>
<br>
1) Move the old animator.cpp into deprecated/ and create a whole new<br>
animator.cpp with a whole new Plasma::Animator? If so, how is this<br>
"extend Plasma::Animator"?</blockquote><div><br>Yes move it just. And create a new class for now.<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
2) Move the old animator.cpp into deprecated/ and extend it in the new<br>
animator.cpp? Then, this doesn't solve the naming issue(We still have<br>
to use a different name, not "Animator"), and it isn't "retro-fitting<br>
Animation".</blockquote><div><br>You can't remove it completly, symbols have to be here for binary compatibilty reasons.<br>Grab a name (can't be Animator), the one you want, we will see later.<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
3) Something else that I didn't quite get?<br>
<font color="#888888"><br>
--<br>
~ mali (<a href="http://constant.inople.net/" target="_blank">http://constant.inople.net/</a>)<br>
_______________________________________________<br>
Plasma-devel mailing list<br>
<a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/plasma-devel" target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br>
</font></blockquote></div><br>