Review Request: Allow keyboard only usage of the Konsole Session Applet

Conrad Hoffmann conrausch at gmx.de
Thu Aug 20 14:17:04 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1366/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

The Konsole session applet can be configured to pop up via a keyboard shortcut and the listed session can be navigated via the up and down arrow keys. Yet, a session can not be started by means of using the keyboard, a mouse click is currently required.

The attached patch fixes the problem by using the QTreeView::activated signal instead of the clicked signal. This also elegantly handles the single/double click issue.

As requested here: http://reviewboard.kde.org/r/1358/


Diffs
-----

  /trunk/KDE/kdeplasma-addons/applets/konsoleprofiles/konsoleprofilesapplet.cpp 1013640 

Diff: http://reviewboard.kde.org/r/1366/diff


Testing
-------

This is the exact same change as in http://reviewboard.kde.org/r/1358/ .
Nevertheless, I have compiled and installed it on my system and verified that it works as expected. Notably, it still obeys the system wide single/double click setting.


Thanks,

Conrad



More information about the Plasma-devel mailing list