Review Request: Allow keyboard only usage of the Konsole Session Applet

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1366/#review2095
-----------------------------------------------------------

Ship it!


yes, same fix, same answer .. :) these kinds of fixes can just go directly into svn, really. they are trivial enough to be caught on the commit log mailing list. of course, if you want the confirmation i'm sure we're more than happy to review whatever you put up :)

- Aaron


On 2009-08-20 12:17:04, Conrad Hoffmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1366/
> -----------------------------------------------------------
> 
> (Updated 2009-08-20 12:17:04)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> The Konsole session applet can be configured to pop up via a keyboard shortcut and the listed session can be navigated via the up and down arrow keys. Yet, a session can not be started by means of using the keyboard, a mouse click is currently required.
> 
> The attached patch fixes the problem by using the QTreeView::activated signal instead of the clicked signal. This also elegantly handles the single/double click issue.
> 
> As requested here: http://reviewboard.kde.org/r/1358/
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeplasma-addons/applets/konsoleprofiles/konsoleprofilesapplet.cpp 1013640 
> 
> Diff: http://reviewboard.kde.org/r/1366/diff
> 
> 
> Testing
> -------
> 
> This is the exact same change as in http://reviewboard.kde.org/r/1358/ .
> Nevertheless, I have compiled and installed it on my system and verified that it works as expected. Notably, it still obeys the system wide single/double click setting.
> 
> 
> Thanks,
> 
> Conrad
> 
>