Review Request: Fix a wrong source update when mounting a StorageVolume

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1352/#review2090
-----------------------------------------------------------



trunk/KDE/kdebase/workspace/plasma/dataengines/soliddevice/soliddeviceengine.cpp
<http://reviewboard.kde.org/r/1352/#comment1413>

    that's going to call updateSourceEvent on ALL of the sources; i don't think that's what's wanted here.
    
    the scheduleSourcesUpdated() call shouldn't be necessary in any case since setData always results in a call to that if appropriate.
    
    in the engine, updateSourceEvent has this code in it:
    
        bool update1 = updateFreeSpace(source);
        bool update2 = updateHardDiskTemperature(source);
    
    so obviously what's needed here is a call not to updateAllSources, but:
    
        updateFreeSpace(udi);
        updateHardDiskTemparature(udi);


- Aaron


On 2009-08-18 15:06:57, Alessandro Diaferia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1352/
> -----------------------------------------------------------
> 
> (Updated 2009-08-18 15:06:57)
> 
> 
> Review request for Plasma, Sebastian Kügler and Christopher Blauvelt.
> 
> 
> Summary
> -------
> 
> This patch fixes a missing update specifically for the "Free Space" key for the data associated with the source of the StorageVolume. I don't know if the missing update is due to the recent changes in Plasma::DataEngine but this patch seems to solve the problem I've pointed out in the "free space indicator patch" (http://reviewboard.kde.org/r/632/#review2065). As from the docs there's no need to call scheduleSourcesUpdate() when using DataEngine::setData, but i found the need to call updateAllSources in order to correctly update the "Free Space" data.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/dataengines/soliddevice/soliddeviceengine.cpp 1012848 
> 
> Diff: http://reviewboard.kde.org/r/1352/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alessandro
> 
>