Review Request: Fix a wrong source update when mounting a StorageVolume

Alessandro Diaferia alediaferia at gmail.com
Tue Aug 18 17:06:58 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1352/
-----------------------------------------------------------

Review request for Plasma, Sebastian Kügler and Christopher Blauvelt.


Summary
-------

This patch fixes a missing update specifically for the "Free Space" key for the data associated with the source of the StorageVolume. I don't know if the missing update is due to the recent changes in Plasma::DataEngine but this patch seems to solve the problem I've pointed out in the "free space indicator patch" (http://reviewboard.kde.org/r/632/#review2065). As from the docs there's no need to call scheduleSourcesUpdate() when using DataEngine::setData, but i found the need to call updateAllSources in order to correctly update the "Free Space" data.


Diffs
-----

  trunk/KDE/kdebase/workspace/plasma/dataengines/soliddevice/soliddeviceengine.cpp 1012848 

Diff: http://reviewboard.kde.org/r/1352/diff


Testing
-------


Thanks,

Alessandro



More information about the Plasma-devel mailing list