Review Request: Improved extender theming

[Aaron J. Seigo]

On Saturday 18 October 2008, Rob Scheepmaker wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/222/
> -----------------------------------------------------------

the diff on reviewboard seems broken, so i'll just reply here instead...

> Summary
> -------
>
> This is an attempt to make the appearance of extenders look more like this
> mockup made by pinheiro:

the screenshot included looks very sweet. nice to see that in action and not 
just a mockup now =)

> - Added a virtual enabledBorderForItem(ExtenderItem*) to Extender.
> Depending on the setting of appearance, and the position of the item, this
> returns which background borders to enable.

why is it virtual?

> - Changed Dialog to check if it contains an extender, and in this case
> automatically enable the correct borders and set the correct margins of
> itself.

would be interested in seeing this part of the patch in particular ..

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20081018/fd82dd7c/attachment.sig