Review Request: Improved extender theming

[Rob Scheepmaker]

On Saturday 18 October 2008 21:33:03 Aaron J. Seigo wrote:
> On Saturday 18 October 2008, Rob Scheepmaker wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.vidsolbach.de/r/222/
> > -----------------------------------------------------------
>
> the diff on reviewboard seems broken, so i'll just reply here instead...

Inconvenient. See the attached diff.
>
> > Summary
> > -------
> >
> > This is an attempt to make the appearance of extenders look more like
> > this mockup made by pinheiro:
>
> the screenshot included looks very sweet. nice to see that in action and
> not just a mockup now =)
>
> > - Added a virtual enabledBorderForItem(ExtenderItem*) to Extender.
> > Depending on the setting of appearance, and the position of the item,
> > this returns which background borders to enable.
>
> why is it virtual?

So that subclasses of extender can do something sane here. Else it would only 
work if your custom extender uses a vertical layout.

>
> > - Changed Dialog to check if it contains an extender, and in this case
> > automatically enable the correct borders and set the correct margins of
> > itself.
>
> would be interested in seeing this part of the patch in particular ..

here it is :)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: extendertheming.diff
Type: text/x-patch
Size: 48134 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20081018/a7a8f82e/attachment-0001.diff