Review Request: Improved extender theming

[Rob Scheepmaker]

On Sunday 19 October 2008 13:38:24 Marco Martin wrote:
> On Saturday 18 October 2008, Nuno Pinheiro wrote:
> > > Diff: http://reviewboard.vidsolbach.de/r/222/diff
> > >
> > >
> > > Testing
> > > -------
> > >
> > > Done some testing om kuiserver and clock.
> > >
> > >
> > > Screenshots
> > > -----------
> > >
> > > Screenshot of new extender theming
> > >   http://reviewboard.vidsolbach.de/r/222/s/83/
> >
> > Beter beter but still some visual glitches (like the un AA corners)....
> > and the bar under is not needed its just shown if the extender is actulay
> > detached...
>
> antialiasing depends from compositing active/inactive, with compositing on
> looks something like this:
> http://www.notmart.org/misc/extender_compositing.png
> border without aa should be needed just for the first one, but for how
> plasma::theme works would be a bit of an hassle and don't think is really
> an issue since this way all the elements looks coherent, without
> antialiasing but coherent :)
>
> just some minor things:
> the return to applet button is a bit misplaced (and in the other screenshot
> was ok, that's weird), btw seems really nother qgraphicslinearlayout bug

Ah, my bad, see the updated diff in this threat.
>
> the calendar is a bit cutted at bottom(also this was ok on the other one,
> strange) i also get for instance email notifications with the same problem
>
> oh, and the dialog is placed one pixel too high so there is an empty line
> (applet::popupposition misbehaving?)

That's still a problem, I'm investigating.