Review Request: zoomed out toolbox outside of containments

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/289/
-----------------------------------------------------------

(Updated 2008-11-29 14:44:41.696266)


Review request for Plasma.


Summary
-------

this makes the zoomed out toolbox to look like the screenshot, all works, but there is still a little problem.
on the first zoom level the view has a scene rect too little, so the toolboxses of lower desktops don't get shown

a solution could be setting a scene rect by hand at DesktopView::zoomOut() but would be a size augmented of an arbitrary hardcoded value, be 100 or 1000 pixels wouldn't be overly pretty?

edit: another problem: toolbox is too wide for smaller screen resolutions, in that screenshot a 1680 screen is almost filled with toolbox width
so what to do? trying to manually layout the tools in two lines disabling text when it's too wide or trying to put the toolbox on the right? (would be really an huge gap between the left and right containments :/)


Diffs
-----

  /trunk/KDE/kdelibs/plasma/containment.cpp
  /trunk/KDE/kdelibs/plasma/private/containment_p.h
  /trunk/KDE/kdelibs/plasma/private/desktoptoolbox.cpp

Diff: http://reviewboard.vidsolbach.de/r/289/diff


Testing
-------


Screenshots
-----------


  http://reviewboard.vidsolbach.de/r/289/s/96/


Thanks,

Marco