Review Request: zoomed out toolbox outside of containments

Marco Martin notmart at gmail.com
Sat Nov 29 23:27:44 CET 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/289/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

this makes the zoomed out toolbox to look like the screenshot, all works, but there is still a little problem.
on the first zoom level the view has a scene rect too little, so the toolboxses of lower desktops don't get shown

a solution could be setting a scene rect by hand at DesktopView::zoomOut() but would be a size augmented of an arbitrary hardcoded value, be 100 or 1000 pixels wouldn't be overly pretty?


Diffs
-----

  /trunk/KDE/kdelibs/plasma/containment.cpp
  /trunk/KDE/kdelibs/plasma/private/containment_p.h
  /trunk/KDE/kdelibs/plasma/private/desktoptoolbox.cpp

Diff: http://reviewboard.vidsolbach.de/r/289/diff


Testing
-------


Screenshots
-----------


  http://reviewboard.vidsolbach.de/r/289/s/96/


Thanks,

Marco



More information about the Plasma-devel mailing list