Review Request: Bugfix for Folderview bug #175191

Aaron Seigo aseigo at kde.org
Sun Nov 30 18:20:17 CET 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/288/#review276
-----------------------------------------------------------

Ship it!


yes, that's probably sensible.


/trunk/KDE/kdebase/apps/plasma/applets/folderview/folderview.cpp
<http://reviewboard.vidsolbach.de/r/288/#comment228>

    i'm a little surprised that setUrl doesn't call dirListed()->openUrl or updateIconWidget, but Frederik could probably explain why =)


- Aaron


On 2008-11-29 13:10:59, Jesse Zamora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/288/
> -----------------------------------------------------------
> 
> (Updated 2008-11-29 13:10:59)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch is my feeble attempt to fix bug #175191 (https://bugs.kde.org/show_bug.cgi?id=175191). What it does is that if the user accidentally removes the folder the folderview is pointing to, it then just reverts to the home folder. Tell me what you all think about this, and please if you have any suggestions, let me know!
> 
> Xtreme Kommander
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/plasma/applets/folderview/folderview.h
>   /trunk/KDE/kdebase/apps/plasma/applets/folderview/folderview.cpp
>   /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h
>   /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/288/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jesse
> 
>



More information about the Plasma-devel mailing list