review of tabbar

[Marco Martin]

On Wednesday 30 July 2008, Aaron J. Seigo wrote:
> On Wednesday 30 July 2008, Marco Martin wrote:
> > on a logistic note: do i move it to kdereview or can ileave it in
> > playground/widgets/tabbar ?
>
> moving it to kdereview is that standard mechanism.

done :D

> > the thing i am most hesitant on it is the way to make the tabbar
> > vertical: it has to be done from TabBar::setTabBarShape() otherwise the
> > layout of the tabwidget gets broken
> > to me if it would be more simple and supporting only horizontal tabbars
> > would be more than ok, but the fact that it's possible to set it vertical
> > from nativewidget, uhm not good...
>
> this is probably solvable with a bit of creativity. subclass TabBar and
> track the orientation in there; then reimplement tabLayoutChange and check
> when the orientation changes (compare the old to the new) and update the
> look at that point.
bwaaah, i didn't tough about it, uff, done :)

> however, i'm not exactly sure what you mean by "layout .. get broken". what
> aspect of the layout? do you mean where the widget pages are shown?

i just have to syncronize the horizontal/vertical layout

> > or, even removing the access to nativewidget?
>
> no, that would break the API pattern
oki

Cheers,
Marco Martin