Review Request: This patch add an easy way to up/down brightness only scrolling on battery plasmoid top.

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/286/#review279
-----------------------------------------------------------

Ship it!


float->qreal for portability, otherwise, looks good =)


svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/plasma/applets/battery/battery.cpp
<http://reviewboard.vidsolbach.de/r/286/#comment231>

    use qreal instead of float (portability)



svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/plasma/applets/battery/battery.cpp
<http://reviewboard.vidsolbach.de/r/286/#comment232>

    qreal(0) instead of 0.f



svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/plasma/applets/battery/battery.cpp
<http://reviewboard.vidsolbach.de/r/286/#comment233>

    qreal(100) intead of 100.f


- Aaron


On 2008-11-30 16:34:10, Alex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/286/
> -----------------------------------------------------------
> 
> (Updated 2008-11-30 16:34:10)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> A patch that makes the Battery applet able to increase/decrease the brightness only by scrolling on top.
> 
> 
> Diffs
> -----
> 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/plasma/applets/battery/battery.h
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/plasma/applets/battery/battery.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/286/diff
> 
> 
> Testing
> -------
> 
> I test it in my computer, also ereslibre test it.
> 
> 
> Thanks,
> 
> Alex
> 
>