Review Request: A simple frame to group widgets

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/117/
-----------------------------------------------------------

(Updated 2008-08-01 13:34:16.153869)


Review request for Plasma.


Summary
-------

Update:
support for text labels and background images
parentwidget and stylesheet are present but mostly stubs

This thing has a purpose similar to a QFrame, but like the tabwidget the group widget in plasma are not very useful, so it's a qgraphicswidget reimplementation.
This is quite important as is used by some mockups like http://img70.imageshack.us/img70/9201/wetherfy7.png
its api is near zero, apart choosing if the appearance is flat, sunken or raised
i think even things that don't use directly this widget will use its svg, like the sunken effect of the tabbar


Diffs
-----

  /trunk/KDE/kdebase/workspace/libs/plasma/CMakeLists.txt
  /trunk/KDE/kdebase/workspace/libs/plasma/widgets/frame.h
  /trunk/KDE/kdebase/workspace/libs/plasma/widgets/frame.cpp

Diff: http://reviewboard.vidsolbach.de/r/117/diff


Testing
-------

grouping for buttons like those screenshots


Screenshots
-----------

frame sunken
  http://reviewboard.vidsolbach.de/r/117/s/32/
background png
  http://reviewboard.vidsolbach.de/r/117/s/34/
background svg
  http://reviewboard.vidsolbach.de/r/117/s/35/


Thanks,

Marco