Review Request: A simple frame to group widgets

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/117/#review107
-----------------------------------------------------------


a few small fixes, then it should be ready to go. don't forget to put an entry in the CHANGELOG =)


/trunk/KDE/kdebase/workspace/libs/plasma/widgets/frame.h
<http://reviewboard.vidsolbach.de/r/117/#comment79>

    this should probably say "set the frame's shadow style" to make it seem sensible with the name of the method.



/trunk/KDE/kdebase/workspace/libs/plasma/widgets/frame.h
<http://reviewboard.vidsolbach.de/r/117/#comment78>

    const



/trunk/KDE/kdebase/workspace/libs/plasma/widgets/frame.h
<http://reviewboard.vidsolbach.de/r/117/#comment77>

    const



/trunk/KDE/kdebase/workspace/libs/plasma/widgets/frame.cpp
<http://reviewboard.vidsolbach.de/r/117/#comment80>

    the stylesheet should actually be used to style the widget ;)
    
    i'm ok with this going in incomplete for now, but please put a TODO in there so we don't lose it.


- Aaron


On 2008-08-01 13:34:16, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/117/
> -----------------------------------------------------------
> 
> (Updated 2008-08-01 13:34:16)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Update:
> support for text labels and background images
> parentwidget and stylesheet are present but mostly stubs
> 
> This thing has a purpose similar to a QFrame, but like the tabwidget the group widget in plasma are not very useful, so it's a qgraphicswidget reimplementation.
> This is quite important as is used by some mockups like http://img70.imageshack.us/img70/9201/wetherfy7.png
> its api is near zero, apart choosing if the appearance is flat, sunken or raised
> i think even things that don't use directly this widget will use its svg, like the sunken effect of the tabbar
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/CMakeLists.txt
>   /trunk/KDE/kdebase/workspace/libs/plasma/widgets/frame.h
>   /trunk/KDE/kdebase/workspace/libs/plasma/widgets/frame.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/117/diff
> 
> 
> Testing
> -------
> 
> grouping for buttons like those screenshots
> 
> 
> Screenshots
> -----------
> 
> frame sunken
>   http://reviewboard.vidsolbach.de/r/117/s/32/
> background png
>   http://reviewboard.vidsolbach.de/r/117/s/34/
> background svg
>   http://reviewboard.vidsolbach.de/r/117/s/35/
> 
> 
> Thanks,
> 
> Marco
> 
>