Review Request: A simple frame to group widgets

[Marco Martin]

> On 2008-08-01 11:10:58, Aaron Seigo wrote:
> > the code that is there looks good, but the widget itself does not follow the widget design seen in the other widgets at all.
> > 
> > most importantly, it doesn't support things like stylesheets or text. with text support it would nicely replace not just Frame but also GroupBox as well.
> > 
> > so imho this widget must support text, picture, parentWidget and styleSheet from the standard widget api; it should also support nativeWidget as well and return 0.
> 
> Marco Martin wrote:
>     hmm, also stylesheet functions are dummy, it's just saved internally so styleSheet() returns what is expected

oh, forgotten to add: the setimage function is mostly the one for label, i had to add gzip in the check, because otherwise svgz doesn't work: should i add it also in plasma::label as well?


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/117/#review104
-----------------------------------------------------------


On 2008-08-01 13:34:16, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/117/
> -----------------------------------------------------------
> 
> (Updated 2008-08-01 13:34:16)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Update:
> support for text labels and background images
> parentwidget and stylesheet are present but mostly stubs
> 
> This thing has a purpose similar to a QFrame, but like the tabwidget the group widget in plasma are not very useful, so it's a qgraphicswidget reimplementation.
> This is quite important as is used by some mockups like http://img70.imageshack.us/img70/9201/wetherfy7.png
> its api is near zero, apart choosing if the appearance is flat, sunken or raised
> i think even things that don't use directly this widget will use its svg, like the sunken effect of the tabbar
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/CMakeLists.txt
>   /trunk/KDE/kdebase/workspace/libs/plasma/widgets/frame.h
>   /trunk/KDE/kdebase/workspace/libs/plasma/widgets/frame.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/117/diff
> 
> 
> Testing
> -------
> 
> grouping for buttons like those screenshots
> 
> 
> Screenshots
> -----------
> 
> frame sunken
>   http://reviewboard.vidsolbach.de/r/117/s/32/
> background png
>   http://reviewboard.vidsolbach.de/r/117/s/34/
> background svg
>   http://reviewboard.vidsolbach.de/r/117/s/35/
> 
> 
> Thanks,
> 
> Marco
> 
>