Review Request: Add support for VideoWidget::snapshot()

[Trever Fischer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103872/#review10999
-----------------------------------------------------------

Ship it!


Looks good, per IRC discussion.

- Trever Fischer


On Feb. 5, 2012, 2:20 p.m., Anssi Hannula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103872/
> -----------------------------------------------------------
> 
> Review request for Phonon Backends.
> 
> 
> Description
> -------
> 
> Add support for the snapshot() method of VideoWidget when building with
> gst-plugins-base 0.10.31+.
> 
> This requires Phonon 4.4+, but the support isn't made optional since we
> already require a newer Phonon to successfully build.
> 
> 
> I don't have KDE write access; a "git am"able patch is available at
> http://onse.fi/files/0001-Add-support-for-VideoWidget-snapshot.patch
> 
> 
> Diffs
> -----
> 
>   gstreamer/CMakeLists.txt 79dbb89 
>   gstreamer/videowidget.h 9fe3b9d 
>   gstreamer/videowidget.cpp 0d2a2ad 
> 
> Diff: http://git.reviewboard.kde.org/r/103872/diff/
> 
> 
> Testing
> -------
> 
> Tested that MediaObject::snapshot() works properly with the patch on phonon-gstreamer git master when built against phonon-4.6.0 and gstreamer0.10-plugins-base-0.10.35.
> 
> Also tested with phonon-gstreamer-4.5.1 with the patch against phonon-4.5.1.
> For the record, while not directly related to snapshots, when testing on 4.5.1 I also encountered a bug in gst 'subtitleoverlay' element which caused pipeline state changes to stall in some cases. I fixed that with a patch which got applied upstream: https://bugzilla.gnome.org/show_bug.cgi?id=668097
> Phonon-gstreamer git master doesn't use 'subtitleoverlay' anymore, so it probably is not affected.
> 
> 
> Thanks,
> 
> Anssi Hannula
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/phonon-backends/attachments/20120228/d5b91cd8/attachment.html>