<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103872/">http://git.reviewboard.kde.org/r/103872/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, per IRC discussion.</pre>
<br />
<p>- Trever</p>
<br />
<p>On February 5th, 2012, 2:20 p.m., Anssi Hannula wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Phonon Backends.</div>
<div>By Anssi Hannula.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add support for the snapshot() method of VideoWidget when building with
gst-plugins-base 0.10.31+.
This requires Phonon 4.4+, but the support isn't made optional since we
already require a newer Phonon to successfully build.
I don't have KDE write access; a "git am"able patch is available at
http://onse.fi/files/0001-Add-support-for-VideoWidget-snapshot.patch</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested that MediaObject::snapshot() works properly with the patch on phonon-gstreamer git master when built against phonon-4.6.0 and gstreamer0.10-plugins-base-0.10.35.
Also tested with phonon-gstreamer-4.5.1 with the patch against phonon-4.5.1.
For the record, while not directly related to snapshots, when testing on 4.5.1 I also encountered a bug in gst 'subtitleoverlay' element which caused pipeline state changes to stall in some cases. I fixed that with a patch which got applied upstream: https://bugzilla.gnome.org/show_bug.cgi?id=668097
Phonon-gstreamer git master doesn't use 'subtitleoverlay' anymore, so it probably is not affected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>gstreamer/CMakeLists.txt <span style="color: grey">(79dbb89)</span></li>
<li>gstreamer/videowidget.h <span style="color: grey">(9fe3b9d)</span></li>
<li>gstreamer/videowidget.cpp <span style="color: grey">(0d2a2ad)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103872/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>