Emailing: queue.patch

[Thierry Bastian]

Right for the coding style. I'll submit that ASAP.

Thierry

-----Original Message-----
From: Matthias Kretz [mailto:kretz at kde.org] 
Sent: mardi 4 décembre 2007 15:18
To: Thierry Bastian
Cc: phonon-backends at kde.org
Subject: Re: Emailing: queue.patch

Hi Thierry,

On Tuesday 04 December 2007, Thierry Bastian wrote:
> Hello Matthias,
>
> After a discussion with Richard, we think that it makes sense that if 
> you enqueue sources in the MediaObject and this mediaObject doesn't 
> have loaded a current source, the first item of the queue should 
> become the current source.
> Attached is a patch that would change this.
>
> Any comment is very welcome.

Good catch. I agree with the change. Patch looks good except for one little
style thing where kdelibs coding style differs from Qt coding style:

    if (d->mediaSource.type() == MediaSource::Invalid)
        setCurrentSource(source);
    else
        d->sourceQueue << source;

should be

    if (d->mediaSource.type() == MediaSource::Invalid) {
        setCurrentSource(source);
    } else {
        d->sourceQueue << source;
    }

--
________________________________________________________
Matthias Kretz (Germany)                            <><
http://Vir.homelinux.org/
MatthiasKretz at gmx.net, kretz at kde.org,
Matthias.Kretz at urz.uni-heidelberg.de