Emailing: queue.patch

[Matthias Kretz]

Hi Thierry,

On Tuesday 04 December 2007, Thierry Bastian wrote:
> Hello Matthias,
>
> After a discussion with Richard, we think that it makes sense that if you
> enqueue sources in the MediaObject and this mediaObject doesn't have loaded
> a current source, the first item of the queue should become the current
> source.
> Attached is a patch that would change this.
>
> Any comment is very welcome.

Good catch. I agree with the change. Patch looks good except for one little 
style thing where kdelibs coding style differs from Qt coding style:

    if (d->mediaSource.type() == MediaSource::Invalid)
        setCurrentSource(source);
    else
        d->sourceQueue << source;

should be

    if (d->mediaSource.type() == MediaSource::Invalid) {
        setCurrentSource(source);
    } else {
        d->sourceQueue << source;
    }

-- 
________________________________________________________
Matthias Kretz (Germany)                            <><
http://Vir.homelinux.org/
MatthiasKretz at gmx.net, kretz at kde.org,
Matthias.Kretz at urz.uni-heidelberg.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/phonon-backends/attachments/20071204/37346663/attachment.pgp