KDE/kdebase/workspace/plasma/containments/folderview

[Riccardo Iaconelli]

On 5/24/08, Fredrik Höglund <fredrik at kde.org> wrote:
>
> On Saturday 24 May 2008 14:53, Riccardo Iaconelli wrote:
> > SVN commit 812032 by ruphy:
> >
> > Before we make a contaiment out of it (are we going to make it for 4.1
> with the freeze?), and we're able to choose it,
> > at least add an option to make folderview's background transparent, so it
> doesn't hurt your eyes. ;-)
> > Not sure about what doing by default, but I guess I'll keep it opaque (as
> it is now), so people understand that is a
> > plasmoid.
> >
> > ACK'd on review board by logixoul.
>
>
> Hi Riccardo,
>
> When we discussed this patch on IRC yesterday, I pointed out that:
>
> 1) You can't add new UI strings when we're in message freeze.
> 2) The applet should call setBackgroundHints() in constraintsEvent(),
> not init(), and that there's already a commented out call in that function
> that disables the default background.
>
> Aaron also said that he preferred it if we solved this problem by making
> the applet background translucent in the default theme.

That's art issue, I don't want to sound harsh... but it's not really his
field. =)
Plus, we're currently redoing that background...

Since you were present and participated in that discussion I don't
> understand why you went ahead and committed this patch anyway
> without even addressing the technical issues with it.
>
To be sincere, I don't remember at all your objections, just aaron's, and I
thought to have answered those in the associated bug. I've really missed
those... sorry. :\

However, I did completely forget about the string freeze when committing
this patch, and that is a sensible reason why this patch should be reverted.
=)

I will revert this patch now... anyways, what should we do for 4.1?
Translucent folderview by default? Put this patch back in 4.2? Make this
patch default without the GUI option? Leave everything as it is? or...?

Bye,
-Riccardo
-- 
GPG key:
3D0F6376
When encrypting, please encrypt also for this subkey:
9EBD7FE1
-----
Pace Peace Paix Paz Frieden Pax Pokój Friður Fred Béke 和平
Hasiti Lapé Hetep Malu Mир Wolakota Santiphap Irini Peoch שלום
Shanti Vrede Baris Rój Mír Taika Rongo Sulh Mir Py'guapy 평화
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/panel-devel/attachments/20080524/b9621202/attachment.html