Review Request: desktop containment switching. this includes http://mattr.info/r/303/

[Chani Armitage]

> On 2008-03-17 11:17:31, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/workspace/libs/plasma/view.cpp, lines 81-82
> > <http://mattr.info/r/304/diff/1/#file1222line81>
> >
> >     this is incorrect; when setScreen is called on the View, it should request the containment for that screen. the View is the view, the Corona is the model.
> >     
> >     so the way this method was originally is correct.

but then it'll set the old screen number on the containment it gets, so it won't *really* set the screen number, so I'll have to set it back... what exactly is supposed to be happening here? what's the point of this function?


- Chani


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/304/#review303
-----------------------------------------------------------


On 2008-03-17 02:39:39, Chani Armitage wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/304/
> -----------------------------------------------------------
> 
> (Updated 2008-03-17 02:39:39)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/containment.h
>   /trunk/KDE/kdebase/workspace/libs/plasma/containment.cpp
>   /trunk/KDE/kdebase/workspace/libs/plasma/view.h
>   /trunk/KDE/kdebase/workspace/libs/plasma/view.cpp
>   /trunk/KDE/kdebase/workspace/plasma/plasma/desktopview.h
>   /trunk/KDE/kdebase/workspace/plasma/plasma/desktopview.cpp
> 
> Diff: http://mattr.info/r/304/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chani
> 
>